Skip to content

Commit 0e81867

Browse files
committed
New version, add support for submission result status "hidden"
1 parent 7f38474 commit 0e81867

File tree

6 files changed

+31
-36
lines changed

6 files changed

+31
-36
lines changed

build.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<target name="-check-mavenmodules">
1212
<uptodate property="mavenmodules.uptodate"
13-
srcfile="maven-wrapper/target/nbm/maven-wrapper-1.29.nbm"
13+
srcfile="maven-wrapper/target/nbm/maven-wrapper-1.30.nbm"
1414
targetfile="mavenmodules"/>
1515
</target>
1616

maven-wrapper/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>fi.helsinki.cs.tmc</groupId>
66
<artifactId>maven-wrapper</artifactId>
7-
<version>1.29</version>
7+
<version>1.30</version>
88
<packaging>nbm</packaging>
99

1010
<name>TMC Maven Wrapper</name>
@@ -46,7 +46,7 @@
4646
<dependency>
4747
<groupId>${project.groupId}</groupId>
4848
<artifactId>core</artifactId>
49-
<version>0.10.11-SNAPSHOT</version>
49+
<version>0.10.13-SNAPSHOT</version>
5050
</dependency>
5151
<dependency>
5252
<groupId>${project.groupId}</groupId>

nbproject/platform.properties

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
branding.token=tmcbeans
22
cluster.path=\
3-
${nbplatform.active.dir}/cnd:\
43
${nbplatform.active.dir}/extide:\
5-
${nbplatform.active.dir}/dlight:\
64
${nbplatform.active.dir}/harness:\
75
${nbplatform.active.dir}/ide:\
86
${nbplatform.active.dir}/java:\
97
${nbplatform.active.dir}/javafx:\
108
${nbplatform.active.dir}/nb:\
119
${nbplatform.active.dir}/platform:\
12-
${nbplatform.active.dir}/webcommon:\
1310
${nbplatform.active.dir}/websvccommon:\
1411
mavenmodules
1512
disabled.modules=\

tmc-plugin/manifest.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ OpenIDE-Module-Requires:
66
org.openide.windows.IOProvider,
77
org.openide.windows.WindowManager
88
OpenIDE-Module-Install: fi/helsinki/cs/tmc/actions/TmcModuleInstall.class
9-
OpenIDE-Module-Specification-Version: 1.2.4
9+
OpenIDE-Module-Specification-Version: 1.2.5

tmc-plugin/src/fi/helsinki/cs/tmc/exerciseSubmitter/ExerciseSubmitter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void bgTaskReady(SubmissionResult result) {
9090
// as we might have unlocked new exercises.
9191
exercise.setAttempted(true);
9292

93-
if (result.getStatus() == SubmissionResult.Status.OK) {
93+
if (result.getStatus() == SubmissionResult.Status.OK || result.getStatus() == SubmissionResult.Status.HIDDEN) {
9494
exercise.setCompleted(true);
9595
}
9696

tmc-plugin/src/fi/helsinki/cs/tmc/ui/TestResultDisplayer.java

Lines changed: 26 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
import fi.helsinki.cs.tmc.langs.domain.RunResult;
1616

1717
import com.google.common.collect.ImmutableList;
18-
import fi.helsinki.cs.tmc.core.domain.ProgressObserver;
1918

2019
import java.awt.Dialog;
2120
import java.awt.event.ActionEvent;
22-
import java.awt.event.ActionListener;
2321
import java.awt.event.WindowAdapter;
2422
import java.awt.event.WindowEvent;
2523
import java.net.URI;
@@ -68,38 +66,38 @@ public void showSubmissionResult(Exercise exercise, SubmissionResult result, fin
6866
clearTestCaseView();
6967
displayError(result.getError());
7068
break;
69+
case HIDDEN:
70+
dialogs.displayMessage("Submission received and saved.\nResults are hidden for this exercise.");
71+
break;
7172
}
7273
}
7374

7475
private void displaySuccessfulSubmissionMsg(Exercise exercise, final SubmissionResult result) {
7576
final SuccessfulSubmissionDialog dialog = new SuccessfulSubmissionDialog(exercise, result);
7677

77-
dialog.addOkListener(new ActionListener() {
78-
@Override
79-
public void actionPerformed(ActionEvent e) {
80-
List<FeedbackAnswer> answers = dialog.getFeedbackAnswers();
81-
if (!answers.isEmpty()) {
82-
Callable<String> task = new TmcServerCommunicationTaskFactory().getFeedbackAnsweringJob(URI.create(result.getFeedbackAnswerUrl()), answers);
83-
BgTask.start("Sending feedback", task, new BgTaskListener<String>() {
84-
@Override
85-
public void bgTaskReady(String result) {
86-
}
87-
88-
@Override
89-
public void bgTaskCancelled() {
90-
}
91-
92-
@Override
93-
public void bgTaskFailed(Throwable ex) {
94-
String msg = "Failed to send feedback :-(\n" + ex.getMessage();
95-
String msgWithBacktrace = msg + "\n" + ExceptionUtils.backtraceToString(ex);
96-
log.log(Level.INFO, msgWithBacktrace);
97-
SwingUtilities.invokeLater(() -> {
98-
dialogs.displayError(msg);
99-
});
100-
}
101-
});
102-
}
78+
dialog.addOkListener((ActionEvent e) -> {
79+
List<FeedbackAnswer> answers = dialog.getFeedbackAnswers();
80+
if (!answers.isEmpty()) {
81+
Callable<String> task = new TmcServerCommunicationTaskFactory().getFeedbackAnsweringJob(URI.create(result.getFeedbackAnswerUrl()), answers);
82+
BgTask.start("Sending feedback", task, new BgTaskListener<String>() {
83+
@Override
84+
public void bgTaskReady(String result) {
85+
}
86+
87+
@Override
88+
public void bgTaskCancelled() {
89+
}
90+
91+
@Override
92+
public void bgTaskFailed(Throwable ex) {
93+
String msg = "Failed to send feedback :-(\n" + ex.getMessage();
94+
String msgWithBacktrace = msg + "\n" + ExceptionUtils.backtraceToString(ex);
95+
log.log(Level.INFO, msgWithBacktrace);
96+
SwingUtilities.invokeLater(() -> {
97+
dialogs.displayError(msg);
98+
});
99+
}
100+
});
103101
}
104102
});
105103

0 commit comments

Comments
 (0)