findBy* for #345 #346
Merged
findBy* for #345 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
previously approved these changes
Apr 5, 2019
alexkrolick
previously approved these changes
Apr 5, 2019
|
This actually isn't enough to fix it for 16.9.0 unfortunately. I'll go ahead and pull this PR and work on it a bit more. Thanks! |
|
Ya I figured, and you might want to put the test somewhere that makes more sense or massage it into something that might detect all the cases you need :) |
|
Thank you for all your work! |
|
Oh, let's keep this open. I'll just update your PR :) |
|
@allcontributors[bot], please add @joual for bug, test, and code |
|
I've put up a pull request to add @joual! 🎉 |
|
🎉 This PR is included in version 6.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
How:
Checklist:
docs site
Closes #345
Closes #347