Skip to content

misc: drop support for node 10 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2021
Merged

misc: drop support for node 10 #58

merged 1 commit into from
Jul 11, 2021

Conversation

nickserv
Copy link
Member

BREAKING CHANGE: node 10 is no longer supported. It reached its end-of-life on 30.04.2021.

BREAKING CHANGE: node 10 is no longer supported. It reached its end-of-life on 30.04.2021.
@nickserv
Copy link
Member Author

While we're at it, would it help if I added Node 12 to the test matrix? That will double the number of builds though, and we already have a bunch for different Puppeteer versions.

@patrickhulce patrickhulce changed the title feat: Drop support for node 10 feat: drop support for node 10 Jul 11, 2021
@patrickhulce patrickhulce changed the title feat: drop support for node 10 misc: drop support for node 10 Jul 11, 2021
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

nah, I think we'll be fine.

@patrickhulce patrickhulce merged commit 48c6159 into main Jul 11, 2021
@patrickhulce patrickhulce deleted the drop-node-10 branch July 11, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants