chore: upgrade to Prettier v3 #932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
==========================================
+ Coverage 96.23% 96.32% +0.08%
==========================================
Files 44 44
Lines 2419 2449 +30
Branches 1000 1019 +19
==========================================
+ Hits 2328 2359 +31
+ Misses 91 90 -1 ☔ View full report in Codecov by Sentry. |
G-Rath
commented
Sep 27, 2024
| @@ -1,4 +1,5 @@ | |||
| module.exports = { | |||
| trailingComma: 'es5', | |||
There was a problem hiding this comment.
note: in v3 the default changes to "all"
I've locked this to the v2 default to reduce the diff in this pull request since as an option it will be very easy to do a follow-up PR switching this default if desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
eslint-plugin-prettiertools/generate-configsto be asyncContext
Prettier v3 removes its sync API, so to upgrade we now have to use promises
Relates to #826 and #855