Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-unnecessary-act): make isStrict option true by default #479

Merged
merged 1 commit into from
Oct 14, 2021
Merged

feat(no-unnecessary-act): make isStrict option true by default #479

merged 1 commit into from
Oct 14, 2021

Conversation

MichaelDeBoey
Copy link
Member

Part of #478

BREAKING CHANGE: isStrict option is now true by default

@MichaelDeBoey MichaelDeBoey added enhancement New feature or request BREAKING CHANGE This change will require a major version bump labels Sep 23, 2021
@MichaelDeBoey MichaelDeBoey added this to the 5.0.0 milestone Sep 23, 2021
@MichaelDeBoey MichaelDeBoey self-assigned this Sep 23, 2021
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 23, 2021
Closed
11 tasks
@MichaelDeBoey MichaelDeBoey force-pushed the make-isStrict-option-true-by-default-for-no-unnecessary-act branch 2 times, most recently from 92e5a23 to e976dd7 Compare September 23, 2021 11:52
@Belco90
Copy link
Member

Belco90 commented Sep 26, 2021 •
edited by MichaelDeBoey
Loading

Tests failing here! Since isStrict is enabled by default now, some tests were assuming it was disabled by default so this PR has to update tests to:

  • explicitly set isStrict to false in test cases without the option
  • remove the isStrict option in test cases where it was explicitly set to true

@Belco90
Copy link
Member

Belco90 commented Oct 13, 2021

I'm afraid there are some conflicts, so this branch must be updated manually.

@MichaelDeBoey MichaelDeBoey force-pushed the make-isStrict-option-true-by-default-for-no-unnecessary-act branch from e976dd7 to fe6f6a5 Compare October 13, 2021 22:20
@MichaelDeBoey
feat(no-unnecessary-act): make isStrict option true by default
8665f5c 
BREAKING CHANGE: `isStrict` option is now `true` by default
@MichaelDeBoey MichaelDeBoey force-pushed the make-isStrict-option-true-by-default-for-no-unnecessary-act branch from fe6f6a5 to 8665f5c Compare October 13, 2021 23:21
Belco90
Belco90 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great approach for the tests!

@Belco90 Belco90 merged commit e3ebef8 into alpha Oct 14, 2021
@Belco90 Belco90 deleted the make-isStrict-option-true-by-default-for-no-unnecessary-act branch October 14, 2021 01:21
@github-actions
Copy link

🎉 This PR is included in version 5.0.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zaicevas zaicevas mentioned this pull request Jan 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees

@MichaelDeBoey MichaelDeBoey

Labels
BREAKING CHANGE This change will require a major version bump enhancement New feature or request hacktoberfest-accepted released on @alpha released
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @Belco90