Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new rule: no-container #171

Closed
nickserv opened this issue Jun 17, 2020 · 5 comments · Fixed by #177
Closed

new rule: no-container #171

nickserv opened this issue Jun 17, 2020 · 5 comments · Fixed by #177
Assignees
@thebinaryfelix
Labels
new rule New rule to be included in the plugin released on @beta released
Milestone
v4

Comments

@nickserv
Copy link
Member

Inspiration: Using container to query for elements

This would error on container methods like querySelector that are often used instead of get/query functions, as there might be other reasons why you'd need to access the container in a test (such as assertions). It would be nice to give suggestions of specific get/query functions as well, but I'm not sure how far we could get.
@nickserv nickserv added the new rule New rule to be included in the plugin label Jun 17, 2020
This was referenced Jun 17, 2020
Closed
Closed
@Belco90 Belco90 added this to the v4 milestone Jun 17, 2020
@thebinaryfelix
Copy link
Contributor

Hi, everyone! I'd like to help implementing this rule, could I be assigned to it @nickmccurdy ?

@gndelia
Copy link
Collaborator

gndelia commented Jun 18, 2020

Sure, it's all yours 😄 You might want to review #165 as well because there were some mentions about this ticket.

@thebinaryfelix
Copy link
Contributor

Thanks @gndelia !

@thebinaryfelix thebinaryfelix mentioned this issue Jun 19, 2020
Merged
@nickserv nickserv linked a pull request Jun 20, 2020 that will close this issue
feat: add no-container rule #177
Merged
@Belco90 Belco90 mentioned this issue Jun 22, 2020
Closed
19 tasks
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thebinaryfelix thebinaryfelix

Labels
new rule New rule to be included in the plugin released on @beta released
Projects
None yet
Milestone
v4
Development

Successfully merging a pull request may close this issue.

feat: add no-container rule thebinaryfelix/eslint-plugin-testing-library
4 participants
@gndelia @nickserv @Belco90 @thebinaryfelix