test: improved coverage for prefer-user-event. applied feedback

testing-library · Nov 8, 2020 · 06cb9cf · 06cb9cf
1 parent f12acf5
commit 06cb9cf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/lib/rules/prefer-user-event.ts b/lib/rules/prefer-user-event.ts
@@ -93,14 +93,14 @@ export default createTestingLibraryRule<Options, MessageIds>({
     return {
       ['CallExpression > MemberExpression'](node: TSESTree.MemberExpression) {
         const util = helpers.findImportedUtilSpecifier('fireEvent');
-        const fireEventAliasOrWildcard = isIdentifier(util)
-          ? util?.name
-          : util?.local.name;
-
-        if (!fireEventAliasOrWildcard) {
+        if (!util) {
           // testing library was imported, but fireEvent was not imported
           return;
         }
+        const fireEventAliasOrWildcard = isIdentifier(util)
+          ? util.name
+          : util.local.name;
+
         const fireEventUsed =
           isIdentifier(node.object) &&
           node.object.name === fireEventAliasOrWildcard;

diff --git a/tests/lib/rules/prefer-user-event.test.ts b/tests/lib/rules/prefer-user-event.test.ts
@@ -178,6 +178,8 @@ ruleTester.run(RULE_NAME, rule, {
         errors: [
           {
             messageId: 'preferUserEvent',
+            line: 4,
+            column: 9,
           },
         ],
       })
@@ -188,7 +190,7 @@ ruleTester.run(RULE_NAME, rule, {
         import * as dom from '${libraryModule}'
         dom.fireEvent.${fireEventMethod}(foo)
       `,
-        errors: [{ messageId: 'preferUserEvent' }],
+        errors: [{ messageId: 'preferUserEvent', line: 3, column: 9 }],
       })
     ),
     ...createScenarioWithImport<InvalidTestCase<MessageIds, Options>>(
@@ -197,7 +199,7 @@ ruleTester.run(RULE_NAME, rule, {
         const { fireEvent } = require('${libraryModule}')
         fireEvent.${fireEventMethod}(foo)
       `,
-        errors: [{ messageId: 'preferUserEvent' }],
+        errors: [{ messageId: 'preferUserEvent', line: 3, column: 9 }],
       })
     ),
     ...createScenarioWithImport<InvalidTestCase<MessageIds, Options>>(
@@ -206,7 +208,7 @@ ruleTester.run(RULE_NAME, rule, {
         const rtl = require('${libraryModule}')
         rtl.fireEvent.${fireEventMethod}(foo)
       `,
-        errors: [{ messageId: 'preferUserEvent' }],
+        errors: [{ messageId: 'preferUserEvent', line: 3, column: 9 }],
       })
     ),
     ...Object.keys(MappingToUserEvent).map((fireEventMethod: string) => ({
@@ -217,7 +219,7 @@ ruleTester.run(RULE_NAME, rule, {
         import * as dom from 'test-utils'
         dom.fireEvent.${fireEventMethod}(foo)
       `,
-      errors: [{ messageId: 'preferUserEvent' }],
+      errors: [{ messageId: 'preferUserEvent', line: 3, column: 9 }],
     })),
     ...Object.keys(MappingToUserEvent).map((fireEventMethod: string) => ({
       settings: {
@@ -227,7 +229,7 @@ ruleTester.run(RULE_NAME, rule, {
         import { fireEvent } from 'test-utils'
         fireEvent.${fireEventMethod}(foo)
       `,
-      errors: [{ messageId: 'preferUserEvent' }],
+      errors: [{ messageId: 'preferUserEvent', line: 3, column: 9 }],
     })),
     ...Object.keys(MappingToUserEvent).map((fireEventMethod: string) => ({
       settings: {
@@ -237,7 +239,7 @@ ruleTester.run(RULE_NAME, rule, {
         import { fireEvent as fireEventAliased } from 'test-utils'
         fireEventAliased.${fireEventMethod}(foo)
       `,
-      errors: [{ messageId: 'preferUserEvent' }],
+      errors: [{ messageId: 'preferUserEvent', line: 3, column: 9 }],
     })),
   ],
 });