-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve error message when passing an Array while a single Element is expected #906
feat: Improve error message when passing an Array while a single Element is expected #906
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b425e0c:
|
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 942 944 +2
Branches 284 285 +1
=========================================
+ Hits 942 944 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor suggestions.
I'm not really sure what went wrong with the validate script. It passes locally. And I do not see a re-run button. Reading a bit into it, it might be an async failure. I think I've seen a PR about some timer shenanigans, it might be related. Lemme know how I should proceed. |
I've just re-ran the jobs but it looks like it's still failing for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks!
🎉 This PR is included in version 7.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@eps1lon I see that it passed in CI, did you just re-run it? |
Yep, it's a flaky test. Seems like others have the same problem: #901 (comment). |
Cool, thanks for the update :) |
What: New error message when passing an Array.
Why: This can be a quick typo when using
screen.getAll*
orscreen.queryAll*
queries.How: Type checking for
Array
.Checklist:
docs site N/A