Fix chain commands with previous subject different of document, element or window #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to commands to be chained with a previous command that not returns a document, element or window FIX #114
leosuncin
changed the title
leosuncin
changed the title
NicholasBoll
reviewed
Feb 3, 2020
|
|
||
| it('should chain findBy* with subject different of document, element or window', () => { | ||
| cy.wrap(true) | ||
| .should('be.true') |
There was a problem hiding this comment.
This is a good test to verify the functionality 👍
kentcdodds
approved these changes
Feb 3, 2020
|
@all-contributors please add @leosuncin for bugs, code, and tests |
|
I've put up a pull request to add @leosuncin! 🎉 |
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Allow commands to be chained when previous command does not returns document, element or window
Why:
Fix #114
How:
Remove document, element or window from
prevSubjectincreateCommandChecklist: