-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious dependency on ordereddict #18
Comments
This is particularly bad for users of conda and python2.7, because conda refuses to install ordereddict with a python2.7 environment. A workaround is to manually install it using pip: pip install ordereddict |
I'm flat out travelling next week, but if someone wants to put up a PR changing this to a marker driven conditional dependency that would be great. Be sure to either set a setup_requires minimum new enough to support that, or use the hack of putting markers in extras_require. |
A solution here would be great. |
I've submitted a pull request, #19. Does that cover everything? |
Thanks @johanbrandhorst but no - procedural code like that is incompatible with wheels - need to use PEP 508 markers instead. There's a bit of a hack to get older setuptools to handle them which I've used - see the commit that closed this for an example. I've released 1.0.1 to get the fix out there. |
Great job @rbtcollins 😄 |
The
setup.py
now inconditionally specifies a dependency onordereddict
, while it's only necessary for Python 2.6 and earlier.The text was updated successfully, but these errors were encountered: