Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious dependency on ordereddict #18

Closed
pitrou opened this issue Apr 13, 2016 · 6 comments
Closed

Spurious dependency on ordereddict #18

pitrou opened this issue Apr 13, 2016 · 6 comments

Comments

@pitrou
Copy link

pitrou commented Apr 13, 2016

The setup.py now inconditionally specifies a dependency on ordereddict, while it's only necessary for Python 2.6 and earlier.

@johanbrandhorst
Copy link

This is particularly bad for users of conda and python2.7, because conda refuses to install ordereddict with a python2.7 environment. A workaround is to manually install it using pip:

pip install ordereddict

@rbtcollins
Copy link
Member

I'm flat out travelling next week, but if someone wants to put up a PR changing this to a marker driven conditional dependency that would be great. Be sure to either set a setup_requires minimum new enough to support that, or use the hack of putting markers in extras_require.

@gnurser
Copy link

gnurser commented Apr 22, 2016

A solution here would be great.

@johanbrandhorst
Copy link

I've submitted a pull request, #19. Does that cover everything?

@rbtcollins
Copy link
Member

Thanks @johanbrandhorst but no - procedural code like that is incompatible with wheels - need to use PEP 508 markers instead. There's a bit of a hack to get older setuptools to handle them which I've used - see the commit that closed this for an example.

I've released 1.0.1 to get the fix out there.

@johanbrandhorst
Copy link

Great job @rbtcollins 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants