Commit 6c7019b
authored
refactor: replace dirs crate with etcetera (#736)
I recently learned that [`dirs`](https://crates.io/crates/dirs) depends
on [`option-ext`](https://crates.io/crates/option-ext) via
[`dir-sys`](https://crates.io/crates/dirs-sys) (as of `dir-sys` 0.4.1
that came in as part of `dirs` 5.0.1), which is MPL 2.0 licensed.
[It does not appear that the author is interested reconsidering their
stance on
licensing](dirs-dev/dirs-sys-rs#21 (comment)),
which unfortunately creates some complications for projects under the
CNCF umbrella (as well as many corporate projects), and so I thought I
would propose switching `dirs` out for `etcetera` since it is MIT or
Apache 2.0 licensed.
As you can see from the linked thread, this is a fairly common
limitation for adoption, so in the interest of enabling further
adoption, I believe it would be in the best interest for
`testcontainers-rs` to reconsider this dependency, especially
considering how trivial it is to replace 🙂
FWIW, I have done testing on my end to ensure that the changes I'm
proposing produce similar results under Mac OS and Linux, but since I
don't have direct access to Windows I can't say with 100% certainty that
they do though from reading through the code across both libraries, I
feel fairly confident that they should.
Signed-off-by: Joonas Bergius <joonas@bergi.us>1 parent 3168f25 commit 6c7019b
2 files changed
+12
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
26 | 25 | | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
198 | 206 | | |
199 | 207 | | |
200 | 208 | | |
| |||
210 | 218 | | |
211 | 219 | | |
212 | 220 | | |
213 | | - | |
| 221 | + | |
214 | 222 | | |
215 | 223 | | |
216 | 224 | | |
| |||
0 commit comments