fix(DinD): add feature flag to re-enable DinD #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderankin
changed the title
alexanderankin
referenced
this pull request
Sep 10, 2024
#388) ## What does this PR do? Adds support for reading the `tc.host` property from the `~/.testcontainers.properties` file. This config will have the highest priority for configuring the Docker client. ## Why is it important This brings [Testcontainers Desktop](https://testcontainers.com/desktop/) support to testcontainers-python and aligns this language with the `TestcontainersHostStrategy` found it testcontainers-java. ## Misc I wasn't able to get a working testcontainers-python development environment set up on my M2 MacBook. This seems to be related to some kind of Cython 3.0.0 issue, that I don't fully understand and trying to fix it breaks the installation of further dependencies (like pymssql). So I was only able to test it in an Ubuntu Codespaces environment (also required some weird Cython workarounds). ## Breaking Changes - To prioritise `tc.host` this PR prioritised having that over true `docker:dind` use cases - This means we stopped trying to automatically infer the container host IP when running inside a `docker:dind` container - When using `-v /var/run/docker.sock:/var/run/docker.sock` you should be unaffected since your containers run on the original host --------- Co-authored-by: Bálint Bartha <39852431+totallyzen@users.noreply.github.com> Co-authored-by: David Ankin <daveankin@gmail.com>
alexanderankin
force-pushed
the
dind-flag
branch
from
5fbeef9
to
97e426f
Compare
alexanderankin
pushed a commit
that referenced
this pull request
Oct 23, 2024
closes #475 One step closer to solve #517 Replaces #622 According to the [data collected](#475 (comment)) this should fix issues running testcontainers inside a container in almost all cases. There is still an issue when running it within docker desktop, that is probably easily solved which checking for the existence of `host.docker.internal`. But I have to recollect the data to ensure this, so this will be added at later point in time, as with with setting `-e TESTCONTAINERS_HOST_OVERRIDE=host.docker.internal` an easy workaround exists as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature flag to make DinD usable in a "backwards-compatible" way.
also fixes the ci/tests for it