Skip to content

Conversation

@Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented May 28, 2024

Make the Readme display some more details regarding the project:

  • using ruff (just a nice reference)
  • pypi version (good visibility)
  • license (good visibility)
  • supported python versions (good visibility)
  • code coverage reporting (main driver for this PR)

image

Relates to #544 - export code coverage (e.g. to codecov)

@alexanderankin alexanderankin changed the title Display status on readme chore(core): Display status on readme May 28, 2024
@Tranquility2 Tranquility2 force-pushed the export_code_coverage branch 2 times, most recently from ca50fa3 to b9af15a Compare May 28, 2024 21:06
@codecov
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@54c88cf). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage        ?   74.95%           
=======================================
  Files           ?       10           
  Lines           ?      547           
  Branches        ?       78           
=======================================
  Hits            ?      410           
  Misses          ?      110           
  Partials        ?       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DEBUG: downloaded files

remove debug

undo debug
@Tranquility2 Tranquility2 force-pushed the export_code_coverage branch from a8d7875 to f8d744d Compare May 28, 2024 21:29
@Tranquility2
Copy link
Contributor Author

Tranquility2 commented May 28, 2024

https://github.com/testcontainers/testcontainers-python/actions/runs/9276601581/job/25524084272

error - 2024-05-28 21:31:54,280 -- Upload failed: {"detail":"Tokenless has reached GitHub rate limit. 
Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. 
Expected available in 221 seconds."}

Looks like CODECOV_TOKEN is needed in secrets

@alexanderankin alexanderankin merged commit 54822de into testcontainers:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants