Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect server URL in RegistryAuthLocator#lookupAuthConfig when a credential helper doesn’t include the server URL in its response #9055

Open
eager-signal opened this issue Aug 1, 2024 · 0 comments · May be fixed by #9056
Labels

Comments

@eager-signal
Copy link

Module

Core

Testcontainers version

1.20.0

Using the latest Testcontainers version?

Yes

Host OS

Linux, macOS

Host Arch

x86, ARM

Docker version

Client: Docker Engine - Community
 Version:           20.10.17
 API version:       1.41
 Go version:        go1.18.3
 Git commit:        100c70180f
 Built:             Mon Jun  6 21:36:39 2022
 OS/Arch:           darwin/arm64
 Context:           default
 Experimental:      true

What happened?

Some credential helpers (like docker-credential-ecr-login) return the server URL for get, while others (like docker-credential-gcloud) don’t. For these helpers, the resulting AuthConfig contains the value of com.github.dockerjava.api.model.AuthConfig.DEFAULT_SERVER_ADDRESS.

We’d expect the RegistryAuthLocator to fall back to the server URL from the query, just like the logic in the first-party credential helper tool.

Relevant log output

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant