Skip to content

Conversation

alexander-jesner-AP
Copy link
Contributor

What does this PR do?

When searching up the directory tree for solution files, also consider *.slnx files that were recently introduced.

Why is it important?

Establishes compatibility with the future solution format.

Related issues

Fixes #1491

Copy link

netlify bot commented Jul 25, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 3fca766
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/6883483404d81b00086e0b17
😎 Deploy Preview https://deploy-preview-1492--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Jul 25, 2025
@HofmeisterAn HofmeisterAn changed the title When searching up the directory tree for solution files, also consider *.slnx feat: Resolve .slnx (solution) file in the common directory paths Jul 25, 2025
@HofmeisterAn HofmeisterAn changed the title feat: Resolve .slnx (solution) file in the common directory paths feat: Resolve .slnx (solution) file in common directory paths Jul 25, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@HofmeisterAn HofmeisterAn merged commit 5565c15 into testcontainers:develop Jul 25, 2025
134 of 137 checks passed
@alexander-jesner-AP alexander-jesner-AP deleted the slnx branch July 25, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CommonDirectoryPath.GetSolutionDirectory does not work with new .slnx format

2 participants