Skip to content

Conversation

scrocquesel-ml150
Copy link
Contributor

What does this PR do?

This PR improve the eventHub service configuration builder.

  1. It uses the correct default namespace name, thus removing the warning

    Recoverable validation failed on user config:Expected string to be "emulatorns1" with a length of 11 because NamespaceName is non-modifiable.Only supported emulatorns1, but "ns-1" has a length of 4, differs near "ns-" (index 0).
    
  2. It allows to pass an empty consumerGroup array and an array containing $default. This consumer group is always created by the emulator.

  3. It limits the number of hubs that can be created as per the emulator quotas.

  4. In case the configuration is still invalid, it doesn't wait indefinitely on a stopped container.

Why is it important?

In my test cases, I use the constant provided by the SDK EventHubConsumerClient.DefaultConsumerGroupName (= $default) and it was not possible to configure the container with only this consumer group.

Related issues

Copy link

netlify bot commented Apr 22, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit f9c8b62
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6808f6d8e44a0d0008550836
😎 Deploy Preview https://deploy-preview-1432--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added bug Something isn't working enhancement New feature or request labels Apr 23, 2025
@HofmeisterAn HofmeisterAn changed the title fix(EventHubs): improve eventhubs configuration builder fix(EventHubs): Support default consumer group name Apr 23, 2025
@HofmeisterAn HofmeisterAn merged commit a8b0fb6 into testcontainers:develop Apr 23, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: EventHub configuration produce errors

2 participants