Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state[:password] not getting populated if Admin password is provided #444

Open
gcorpian opened this issue Feb 14, 2019 · 0 comments
Open

Comments

@gcorpian
Copy link

I am working with a custom Windows AMI and since it is failing to get the admin password, I created a static password for the Administrator account and added it to the kitchen.yml instance.transport control. This results in the function fetch_windows_admin_password never getting called. Looking through the code, I can't see instances outside of that function where state[:password] gets populated. The problem this presents is that the line instance.transport.connection(state).wait_until_ready doesn't exit because no password was provided so it keeps waiting for the connection to be ready.

I see a few things needing to be done.

  1. state[:password] should be populated when instance.transport[:password] is not nil.
  2. A break should occur if instance.transport.connection(state).wait_until_ready exceeds a certain length of time.
  3. A validation check put in place to ensure all required values are populated before requesting a connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants