Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HueWheel uniformity issue #336

Closed
3 tasks done
drwpow opened this issue Nov 4, 2024 · 0 comments · Fixed by #351
Closed
3 tasks done

HueWheel uniformity issue #336

drwpow opened this issue Nov 4, 2024 · 0 comments · Fixed by #351
Labels
bug Something isn't working good first issue Good for newcomers help wanted PRs are welcome!

Comments

@drwpow
Copy link
Collaborator

drwpow commented Nov 4, 2024

Description

The “good” don’t look so good anymore. Fix the regression in the darkening of the band. It doesn’t have to be the most saturated, but it should show the widest range of colors

Definition of done

  • Ideally the gradient operates on the OKLAB or OKLCH space. OKHSL is workable, too, if there’s a good argument to use that
  • HueWheel follows good recommendations outlined in CSS Color Module 4 such as alpha and color interpretation, which touch on color blending
  • The ideal solution is neither too saturated no desaturated. It is one where every line has a distinct hue, and hues appear even in size.

Notes

  • Read Two new color spaces for color picking - Okhsv and Okhsl. This is a great summary of the trade-offs between mathematically-uniform colors vs perceptually-uniform colors vs an artistic blend between the two. We’re shooting for the artistic blend here, so some subjectivity is required
@drwpow drwpow converted this from a draft issue Nov 4, 2024
@drwpow drwpow added bug Something isn't working help wanted PRs are welcome! good first issue Good for newcomers labels Nov 4, 2024
@drwpow drwpow changed the title ColorPicker hue issue HueWheel uniformity issue Nov 4, 2024
@drwpow drwpow mentioned this issue Nov 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap 2.0 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted PRs are welcome!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant