fix: Add input validation for security group creation

[akocbek]

Description

The user incorrectly used SGs with VSI. He wanted to attach existing SG with a new VSI using var.create_security_group=false and set value of var.security_group.

Therefore, the output error occurred.

Instead, to append existing SG to VSI var.security_group_ids needs to be used.

To prevent this behavior new input validation was added which checks if var.create_security_group=false then var.security_group shouldn't have the value.
In addition extra check was added to vsi_security_group output to prevent error to occur again.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

• When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
• Merge by using "Squash and merge".

[akocbek]

/run pipeline

[ocofaigh]

Give security_group a default value of null and then add one more validation block:

validate_security_group_2 = var.create_security_group == true && var.security_group == null ? tobool("var.security_group cannot be null when var.create_security_group is true.") : true

[akocbek]

/run pipeline

[ocofaigh]

Error: [ERROR] Error creating authorization policy: The policy wasn't created because an access policy with identical attributes already exists. Please update the roles in the existing policy (f00508a3-d07d-4831-b0be-bf797fd5f654), or update the one you're trying to assign to include a different attribute assignment.

Known issue when parallel PRs running for this repo. Will retry when account clean of this auth policy

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 2.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀