-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init vsi terraform module #1
Conversation
Co-authored-by: Jennifer Valle <jvallexm@gmail.com>
* feat: Add pre-commit checks * feat: Add pre-commit checks * feat: Add pre-commit checks * feat: Add pre-commit checks * feat: Add pre-commit checks Co-authored-by: Andrej Kocbek <akocbek@ie.ibm.com>
@akocbek - pre-commit are passing, but there are errors in the test. See https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/runs/7076174260?check_suite_focus=true#step:6:159 |
* fix: example do not create ssh key if already exists * fix: example do not create ssh key if already exists * fix: example do not create ssh key if already exists * fix: example do not create ssh key if already exists * fix: example do not create ssh key if already exists * fix: example do not create ssh key if already exists Co-authored-by: Andrej Kocbek <akocbek@ie.ibm.com>
@akocbek @argeiger - FYI, I have not looked in details yet TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │Error: image not found |
Co-authored-by: Andrej Kocbek <akocbek@ie.ibm.com>
@argeiger @jvallexm I have added a required permissions section to the readme, but unsure what exact permissions are required. Could you please fill it in? For example, here is what we put for the VPC module -> https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc#required-iam-access-policies |
* fix: resolve idempotency issue by explicitly using the vpc default sg * fix: delay vpcs data lookup until new vpc created
Since I am the creator of the PR, I am not able to approve but the PR LGTM |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.