Skip to content

fix: change the names of vpc_inbound_rule and vpc_outbound_rule #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Draft

fix: change the names of vpc_inbound_rule and vpc_outbound_rule #581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c65a8
fix: change the names of vpc_inbound_rule and vpc_outbound_rule
Aashiq-J Jul 21, 2023
259a381
Merge branch 'main' of https://github.com/terraform-ibm-modules/terra…
Aashiq-J Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions network_acls.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ locals {
])

vpc_inbound_rule = flatten([
for index, cidrs in var.network_cidrs != null ? var.network_cidrs : ["0.0.0.0/0"] : [
for address in data.ibm_is_vpc_address_prefixes.get_address_prefixes.address_prefixes :
for cidr_index, cidr in var.network_cidrs != null ? var.network_cidrs : ["0.0.0.0/0"] : [
for address_index, address in data.ibm_is_vpc_address_prefixes.get_address_prefixes.address_prefixes :
{
name = "ibmflow-allow-vpc-connectivity-inbound-${substr(address.id, -4, -1)}-${index}" # Providing unique rule names
name = "ibmflow-allow-vpc-connectivity-inbound-${address_index}-${cidr_index}" # Providing unique rule names
action = "allow"
source = address.cidr
destination = cidrs
destination = cidr
direction = "inbound"
tcp = null
udp = null
Expand All @@ -83,13 +83,13 @@ locals {
]
])
vpc_outbound_rule = flatten([
for address in data.ibm_is_vpc_address_prefixes.get_address_prefixes.address_prefixes : [
for index, cidrs in var.network_cidrs != null ? var.network_cidrs : ["0.0.0.0/0"] :
for address_index, address in data.ibm_is_vpc_address_prefixes.get_address_prefixes.address_prefixes : [
for cidr_index, cidr in var.network_cidrs != null ? var.network_cidrs : ["0.0.0.0/0"] :

{
name = "ibmflow-allow-vpc-connectivity-outbound-${substr(address.id, -4, -1)}-${index}"
name = "ibmflow-allow-vpc-connectivity-outbound-${address_index}-${cidr_index}"
action = "allow"
source = cidrs
source = cidr
destination = address.cidr
direction = "outbound"
tcp = null
Expand Down