Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: allow null service_account #262

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

Shabirmean
Copy link
Contributor

Description

  • The service_account variable for the instant_template module is a required variable
  • This variable is used as part of the content section of the dynamic block for the google_compute_instance_template resource from the provider
  • Thus, it is not possible to create an instant template with no service account associated with it
  • As a result it's not possible to go from the instant_template module in this repo to a GCE VM which has no service account associated with it

Why is it an issue

  • This is friction full in certain use-cases; for example when installing Anthos bare metal on GCE VMs that have a Service Account associated with it; there are some parts of the install that conflict with this service account
  • Thus we want to be able to create instance_templates which has no service account attached

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shabirmean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants