Add support for resource_policies #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
bharathkkb
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
It would be great to show these in an example as a follow up https://github.com/terraform-google-modules/terraform-google-vm/tree/master/examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for resource policies. Compute instance resource policies can be used to specify maintenance windows or control the physical proximity of instances within the Google Cloud compute infrastructure.
It adds two new variables:
resource_policiesandautomatic_restart.resource_policiesis used to associate an instance with a resource policy via a self_link to the policyautomatic_restartis a variable that was previously set automatically depending on whether or not the instance was preemptible, now it is exposed in the instance_template module so that it can be explicitly set as required when using resource policies.Issue #258 is resolved by this PR.