feat!: Allow setting predictive method for CPU utilization scaling #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
vasyharan
force-pushed
the
master
branch
2 times, most recently
from
a888a9c
to
0a8e4a6
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
bharathkkb
reviewed
Oct 18, 2022
There was a problem hiding this comment.
Thanks for the PR @vasyharan
Looks like we need to update this fixture here here
terraform-google-vm/test/fixtures/mig/autoscaler/main.tf
Lines 25 to 29 in a535e13
|
Thanks for the pointer @bharathkkb (I was not able to see the test logs). This should be addressed now. |
bharathkkb
approved these changes
Oct 19, 2022
bharathkkb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.