Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TPG >=4.74)!: remove ignore maintenance_schedule. Added redis cluster sub-module #195

Merged
merged 8 commits into from
Jan 4, 2024
Merged

fix(TPG >=4.74)!: remove ignore maintenance_schedule. Added redis cluster sub-module #195

merged 8 commits into from
Jan 4, 2024

Conversation

imrannayer
Copy link
Collaborator

@imrannayer imrannayer commented Jan 3, 2024 •
edited
Loading

fix #166
fix #196

@imrannayer imrannayer requested a review from a team as a code owner January 3, 2024 16:58
@imrannayer imrannayer changed the title fix(TPG >=4.74)!: remove ignore maintenance_schedule fix(TPG >=4.74)!: remove ignore maintenance_schedule. Add redis cluster sub-module Jan 4, 2024
@imrannayer imrannayer changed the title fix(TPG >=4.74)!: remove ignore maintenance_schedule. Add redis cluster sub-module fix(TPG >=4.74)!: remove ignore maintenance_schedule. Added redis cluster sub-module Jan 4, 2024
This was referenced Jan 4, 2024
Closed
Closed
bharathkkb
bharathkkb approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imrannayer!

main.tf Show resolved Hide resolved
@imrannayer imrannayer merged commit 10c10ba into terraform-google-modules:master Jan 4, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Jan 4, 2024
Merged
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create sub-module for redis cluster Warning: redundant ignore_changes element (maintenance_schedule)
2 participants
@imrannayer @bharathkkb