Skip to content

Commit e95cde8

Browse files
authored
fix: Update aws_sns_topic_subscription endpoint to use qualified arn (#231)
This commit updates the `aws_sns_topic_subscription` resource to use the `lambda_function_qualified_arn` output for the `endpoint` value. Also bump the `lambda` module to `6.8.0`, which is the latest version that maintains compatability with `aws` v4 provider. Fixes: #230
1 parent 2e72539 commit e95cde8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ See the [functions](https://github.com/terraform-aws-modules/terraform-aws-notif
7676

7777
| Name | Source | Version |
7878
|------|--------|---------|
79-
| <a name="module_lambda"></a> [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 3.2.0 |
79+
| <a name="module_lambda"></a> [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 6.8.0 |
8080

8181
## Resources
8282

main.tf

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ resource "aws_sns_topic_subscription" "sns_notify_slack" {
7373

7474
topic_arn = local.sns_topic_arn
7575
protocol = "lambda"
76-
endpoint = module.lambda.lambda_function_arn
76+
endpoint = module.lambda.lambda_function_qualified_arn
7777
filter_policy = var.subscription_filter_policy
7878
filter_policy_scope = var.subscription_filter_policy_scope
7979
}
8080

8181
module "lambda" {
8282
source = "terraform-aws-modules/lambda/aws"
83-
version = "3.2.0"
83+
version = "6.8.0"
8484

8585
create = var.create
8686

0 commit comments

Comments
 (0)