Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versions): Avoid deprecated resolve_conflicts warning by restricting AWS provider version to <5.0 #2697

Closed
wants to merge 1 commit into from

Conversation

TPXP
Copy link

@TPXP TPXP commented Jul 21, 2023

Description

Since we don't want to bump the AWS provider version we're using, let's add a constraint the other way to avoid the warning.

ref: #2680

Motivation and Context

The latest version of this module does not set an upper bound to the AWS provider version it accepts, which means v5 of the provider can be used, causing the following warning to show up when using EKS addons:

╷
│ Warning: Argument is deprecated
│
│   with aws_eks_addon.this["vpc-cni"],
│   on main.tf line 392, in resource "aws_eks_addon" "this":
│  392:   resolve_conflicts        = try(each.value.resolve_conflicts, "OVERWRITE")
│
│ The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial
│ resource creation. Use "resolve_conflicts_on_create" and/or
│ "resolve_conflicts_on_update" instead
│
│ (and 2 more similar warnings elsewhere)
╵

Breaking Changes

None, this is a bugfix

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…ing AWS provider version to <5.0

Since we don't want to bump the AWS provider version we're using, let's add a constraint the other way to avoid the warning.

ref: terraform-aws-modules#2680
@TPXP TPXP changed the title fix(versions): avoid deprecated resolve_conflicts warning by restricting AWS provider version to <5.0 fix(versions): Avoid deprecated resolve_conflicts warning by restricting AWS provider version to <5.0 Jul 21, 2023
@liviudm
Copy link

liviudm commented Jul 26, 2023

Why not update the module to use resolve_conflicts_on_create and resolve_conflicts_on_update instead of restricting the provider version?

@TPXP
Copy link
Author

TPXP commented Jul 26, 2023

@liviudm This has been suggested here, and rejected because it would be a breaking change #2680

@bryantbiggs
Copy link
Member

Please see #2680 (comment)

We will resolve this warning at the next breaking change

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants