-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Split deprecated resolve_conflicts to resolve_conflicts_on_create/update #2680
Conversation
@@ -4,7 +4,7 @@ terraform { | |||
required_providers { | |||
aws = { | |||
source = "hashicorp/aws" | |||
version = ">= 4.47" | |||
version = ">= 5.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change
this will be resolved at the next breaking change |
So @bryantbiggs in the next update of the module, the deprecation notice will be fixed? or do I need to change anything on our side ? |
you can pin the version of the AWS provider you use to < 5.0 if you are not using any features in 5.0. Unfortunately, Terraform does not provide a way to silence warnings at this time. Both methods are still perfectly valid, the warning is just stating that |
…ing AWS provider version to <5.0 Since we don't want to bump the AWS provider version we're using, let's add a constraint the other way to avoid the warning. ref: terraform-aws-modules#2680
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Deprecation warnings around resolve_conflicts, change to resolve_conflicts_on_create and resolve_conflicts_on_update
Motivation and Context
â Warning: Argument is deprecated
â
â with module.eks_cluster.module.eks.aws_eks_addon.this["kube-proxy"],
â on .terraform/modules/eks_cluster.eks/main.tf line 392, in resource "aws_eks_addon" "this":
â 392: resolve_conflicts = try(each.value.resolve_conflicts, "OVERWRITE")
â
â The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial resource creation. Use "resolve_conflicts_on_create" and/or "resolve_conflicts_on_update" instead
Breaking Changes
Unknown!
How Has This Been Tested?
I have tested these changes in my current environment and deprecation warnings no longer present.