feat: Add input variable 'instance_tags' #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidifraiawork
changed the title
luigidifraiawork
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jun 28, 2023
## [5.2.0](v5.1.0...v5.2.0) (2023-06-28) ### Features * Add input variable 'instance_tags' ([#343](#343)) ([025d3b4](025d3b4))
|
This PR is included in version 5.2.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add input variable
instance_tags, similarly to the VPC module'svpc_tags.Motivation and Context
It allows for fine grained tagging of EC2 instances that can be used by automation tools to perform certain actions, such as cost-saving measures by shutting down instances outside of working hours if they are tagged with e.g.,
Persistence = "09:00-18:00". With this change in place, the extra instance tag would not be set for the volume or IAM role but just for the instance itself, which is the only place where it makes sense.Breaking Changes
None.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request