-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin recreation caused by adding origin shield enabled = false. #142
Comments
It is already a known issue in the Terraform AWS provider - hashicorp/terraform-provider-aws#20659 We can't do anything about it in the module. |
Hi Anton,Probably just comments in complete example would do. :)Many thanks Rafal ZdziechOn 3 May 2024, at 11:22, Anton Babenko ***@***.***> wrote:
It is already a known issue in the Terraform AWS provider - hashicorp/terraform-provider-aws#20659
We can't do anything about it in the module.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There is no need to keep track of Terraform AWS provider issues in the modules. Also, things change in the provider on its own schedule. |
Thanks AntonI am referring to line 82 in this example. Copying example and setting shield to false cause the issue. Removing block instead of setting to false fixed the problem. So some small comment block would save you answering people like me:)Anyway do what is best for you. Thanks for your repositories. terraform-aws-cloudfront/examples/complete/main.tf at master · terraform-aws-modules/terraform-aws-cloudfrontgithub.comMany thanks Rafal ZdziechOn 3 May 2024, at 13:23, Anton Babenko ***@***.***> wrote:
There is no need to keep track of Terraform AWS provider issues in the modules. Also, things change in the provider on its own schedule.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I see what you mean now. You are right. We should comment out that block in the example so that the example looks good and works. Could you do it and open a PR? |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Copied from complete example then just added few bits and remove s3 integration
Steps to reproduce the behavior:
Expected behavior
Do nothing
Actual behavior
Recreated origin
The text was updated successfully, but these errors were encountered: