Requiring Controllers from Transcluded Directives

Author: teropa

src/compile.js

@@ -167,6 +167,7 @@ function $CompileProvider($provide) {
       return function publicLinkFn(scope, cloneAttachFn, options) {
         options = options || {};
         var parentBoundTranscludeFn = options.parentBoundTranscludeFn;
+        var transcludeControllers = options.transcludeControllers;
         if (parentBoundTranscludeFn && parentBoundTranscludeFn.$$boundTransclude) {
           parentBoundTranscludeFn = parentBoundTranscludeFn.$$boundTransclude;
         }
@@ -177,6 +178,9 @@ function $CompileProvider($provide) {
         } else {
           $linkNodes = $compileNodes;
         }
+        _.forEach(transcludeControllers, function(controller, name) {
+          $linkNodes.data('$' + name + 'Controller', controller.instance);
+        });
         $linkNodes.data('$scope', scope);
         compositeLinkFn(scope, $linkNodes, parentBoundTranscludeFn);
         return $linkNodes;
@@ -229,11 +233,13 @@ function $CompileProvider($provide) {
 
             var boundTranscludeFn;
             if (linkFn.nodeLinkFn.transcludeOnThisElement) {
-              boundTranscludeFn = function(transcludedScope, cloneAttachFn, containingScope) {
+              boundTranscludeFn = function(transcludedScope, cloneAttachFn, transcludeControllers, containingScope) {
                 if (!transcludedScope) {
                   transcludedScope = scope.$new(false, containingScope);
                 }
-                return linkFn.nodeLinkFn.transclude(transcludedScope, cloneAttachFn);
+                return linkFn.nodeLinkFn.transclude(transcludedScope, cloneAttachFn, {
+                  transcludeControllers: transcludeControllers
+                });
               };
             } else if (parentBoundTranscludeFn) {
               boundTranscludeFn = parentBoundTranscludeFn;
@@ -403,6 +409,7 @@ function $CompileProvider($provide) {
       var controllerDirectives = previousCompileContext.controllerDirectives;
       var childTranscludeFn;
       var hasTranscludeDirective = previousCompileContext.hasTranscludeDirective;
+      var hasElementTranscludeDirective;
 
       function getControllers(require, $element) {
         if (_.isArray(require)) {
@@ -490,6 +497,7 @@ function $CompileProvider($provide) {
           }
           hasTranscludeDirective = true;
           if (directive.transclude === 'element') {
+            hasElementTranscludeDirective = true;
             var $originalCompileNode = $compileNode;
             $compileNode = attrs.$$element = $(document.createComment(' ' + directive.name + ': ' + attrs[directive.name] + ' '));
             $originalCompileNode.replaceWith($compileNode);
@@ -631,11 +639,15 @@ function $CompileProvider($provide) {
         });
 
         function scopeBoundTranscludeFn(transcludedScope, cloneAttachFn) {
+          var transcludeControllers;
           if (!transcludedScope || !transcludedScope.$watch || !transcludedScope.$evalAsync) {
             cloneAttachFn = transcludedScope;
             transcludedScope = undefined;
           }
-          return boundTranscludeFn(transcludedScope, cloneAttachFn, scope);
+          if (hasElementTranscludeDirective) {
+            transcludeControllers = controllers;
+          }
+          return boundTranscludeFn(transcludedScope, cloneAttachFn, transcludeControllers, scope);
         }
         scopeBoundTranscludeFn.$$boundTransclude = boundTranscludeFn;
 

test/compile_spec.js

@@ -3470,6 +3470,40 @@ describe('$compile', function() {
       });
     });
 
+    it('supports requiring controllers', function() {
+      var MyController = function() { };
+      var gotCtrl;
+      var injector = makeInjectorWithDirectives({
+        myCtrlDirective: function() {
+          return {controller: MyController};
+        },
+        myTranscluder: function() {
+          return {
+            transclude: 'element',
+            link: function(scope, el, attrs, ctrl, transclude) {
+              el.after(transclude());
+            }
+          };
+        },
+        myOtherDirective: function() {
+          return {
+            require: '^myCtrlDirective',
+            link: function(scope, el, attrs, ctrl, transclude) {
+              gotCtrl = ctrl;
+            }
+          };
+        }
+      });
+      injector.invoke(function($compile, $rootScope) {
+        var el = $('<div><div my-ctrl-directive my-transcluder><div my-other-directive>Hello</div></div>');
+
+        $compile(el)($rootScope);
+
+        expect(gotCtrl).toBeDefined();
+        expect(gotCtrl instanceof MyController).toBe(true);
+      });
+    });
+
   });
 
 });