Improved automatic tern-command' setting of tern' executable location.
#930
Conversation
mainly for the case where npm has not installed the executable in a standard executable directory and the tern.el Emacs package has been installed via the Emacs package manager and needs to locate this executable.
| (not (executable-find "npm"))) | ||
| (setq bin-file (or (executable-find "tern") | ||
| (expand-file-name "tern/bin/tern" | ||
| (file-name-directory (shell-command-to-string "npm -g ls --parseable tern")))))) |
There was a problem hiding this comment.
This just returns /home/marijn/prog/node/lib on my system (and tern isn't even installed there). What is it intended to do?
|
When the executable 'tern' is not found in its normal place, it is first looked for within PATH as before and then if not found is searched for within the npm module directories. The return value of those lines is not relevant but what bin-file is set to is. See what that is on your system and then look at the lines following the change which determine if the full path is an existing file or not and then either use that or just use "tern" with no path.
…On Wed, Sep 6, 2017 at 3:56 AM, Marijn Haverbeke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In emacs/tern.el
<#930 (comment)>:
> @@ -99,12 +99,17 @@
(let* ((script-file (or load-file-name
(and (boundp 'bytecomp-filename) bytecomp-filename)
buffer-file-name))
- (bin-file (expand-file-name "../bin/tern" (file-name-directory (file-truename script-file)))))
- (if (file-exists-p bin-file)
+ (bin-file (and script-file (expand-file-name "../bin/tern" (file-name-directory (file-truename script-file))))))
+ (unless (or (and bin-file (file-executable-p bin-file))
+ (not (executable-find "npm")))
+ (setq bin-file (or (executable-find "tern")
+ (expand-file-name "tern/bin/tern"
+ (file-name-directory (shell-command-to-string "npm -g ls --parseable tern"))))))
This just returns /home/marijn/prog/node/lib on my system (and tern isn't
even installed there). What is it intended to do?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#930 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATtnj0z03SqyXWUFqWW8jeFr1ZEsJ3Cxks5sflAmgaJpZM4PNHvG>
.
|
The fallback is already to just run |
|
On Fri, Sep 8, 2017 at 4:02 AM, Marijn Haverbeke ***@***.***> wrote:
where npm has not installed the executable in a standard executable directory
The fallback is already to just run tern though, and it seems start-process runs it in a way that uses the path, so what exactly does this add (except for the npm-based magic, which seems like it'll easily go wrong if you didn't actually use a global npm install for tern)?
The purpose is to find the executable when it has not been installed within a directory in PATH.
As you note, if you install tern globally, it solves this problem. If there are issues with local installs you want to avoid, then just add conditionals for that.
This is solving a real problem I had when first trying to use tern. Let's try to help others avoid the same problem and just handle as many scenarios as reasonably possible.
Bob
|
|
I installed both node and tern globally (npm install -g tern) and yet the emacs tern backend still cannot find my tern-server automatically. I have to set it manually:
If I do not do this, tern does not "run out of the box" for precisely this use-case (which I would think the most common) that Bob describes:
Mari, I agree with Bob that this was definitely a stumbling block for me as a new user. It wasted at least a couple hours of my time (I've been working to get tern/emacs going for the 2nd day now -- this is not the only problem.) IMHO whenever software can work "out of the box" in at least the most common scenarios, we'll gain more happy users, instead of people who just get frustrated and leave. Maybe Bob's code above doesn't work perfectly yet, but I think it is the right idea / direction. |
This is mainly for the case where npm has not installed the executable in a standard executable directory and the tern.el Emacs package has been installed via the Emacs package manager and needs to locate this executable.