Linting and formatting

Author: hoijnet

terminusdb_client/tests/test_schema_overall.py

@@ -300,8 +300,10 @@ class Doc(DocumentTemplate):
         # Call get_instances which should clean up dead refs
         instances = list(Doc.get_instances())
 
-        # Should only have live instances
-        assert all(inst is not None for inst in instances)
+        # Should have fewer instances after cleanup
+        assert len(instances) < initial_count
+        # doc1 should still be alive
+        assert doc1 in instances
 
     def test_to_dict_with_tagged_union(self):
         """Test _to_dict with TaggedUnion inheritance"""
@@ -318,7 +320,7 @@ class ChildB(Base):
             _subdocument = []
 
         # Create tagged union
-        union = TaggedUnion(Base, [ChildA, ChildB])
+        TaggedUnion(Base, [ChildA, ChildB])
 
         # Create instance of child
         child = ChildA(type="A", field_a="value")
@@ -478,7 +480,7 @@ class Parent(GrandParent):
         class Child(Parent):
             child_prop: str
 
-        result = Child._to_dict()
+        Child._to_dict()
 
 
 class TestEmbeddedRep:
@@ -631,7 +633,7 @@ def test_construct_schema_object(self):
         assert isinstance(person, type)
         assert person.__name__ == "Person"
         assert hasattr(person, "__annotations__")
-        assert person.__annotations__["name"] == str
+        assert person.__annotations__["name"] is str
 
     def test_construct_nonexistent_type_error(self):
         """Test _construct_class RuntimeError for non-existent type"""

terminusdb_client/tests/test_scripts.py

@@ -231,8 +231,8 @@ def test_startproject():
         )
 
 
-def test_startproject():
-    """Test project creation"""
+def test_startproject_basic():
+    """Test basic project creation"""
     runner = CliRunner()
     with runner.isolated_filesystem():
         result = runner.invoke(
@@ -954,7 +954,7 @@ def test_branch_delete_current():
             assert "Cannot delete main which is current branch" in str(result.exception)
 
 
-def test_branch_list():
+def test_branch_list_with_current_marked():
     """Test branch listing with current branch marked"""
     runner = CliRunner()
     with runner.isolated_filesystem():
@@ -978,7 +978,7 @@ def test_branch_list():
             assert "  dev" in result.output
 
 
-def test_branch_create():
+def test_branch_create_new():
     """Test creating a new branch"""
     runner = CliRunner()
     with runner.isolated_filesystem():
@@ -1054,7 +1054,7 @@ def test_reset_soft():
             assert "Soft reset to commit abc123" in result.output
 
 
-def test_reset_hard():
+def test_reset_hard_to_commit():
     """Test hard reset to a commit"""
     runner = CliRunner()
     with runner.isolated_filesystem():

terminusdb_client/tests/test_woql_coverage_increase.py

@@ -542,8 +542,8 @@ def test_special_methods(self):
         # immediately returns empty dict when called directly
         assert result == {}
 
-    def test_expand_value_variable_with_list(self):
-        """Test _expand_value_variable with list input"""
+    def test_expand_value_variable_with_list_wrapping(self):
+        """Test _expand_value_variable with list input wrapping"""
         wq = WOQLQuery()
         input_list = ["v:item1", "v:item2", "literal_value"]
         result = wq._expand_value_variable(input_list)

terminusdb_client/tests/test_woql_query_overall.py

@@ -257,10 +257,10 @@ def test_from_woql_invalid_dict_type(self):
 
     def test_from_woql_basic_string_types(self):
         """Test basic string type conversions"""
-        assert from_woql_type("xsd:string") == str
-        assert from_woql_type("xsd:boolean") == bool
-        assert from_woql_type("xsd:double") == float
-        assert from_woql_type("xsd:integer") == int
+        assert from_woql_type("xsd:string") is str
+        assert from_woql_type("xsd:boolean") is bool
+        assert from_woql_type("xsd:double") is float
+        assert from_woql_type("xsd:integer") is int
 
         # As string
         assert from_woql_type("xsd:string", as_str=True) == "str"

terminusdb_client/tests/test_woql_type.py

@@ -609,7 +609,7 @@ def test_embed_obj_skips_xsd_types(self):
 
         all_existing_class = {"Person": {"name": "xsd:string"}}
 
-        result = _embed_obj(df, 1, pd, False, all_existing_class, "Person", mock_client)
+        _embed_obj(df, 1, pd, False, all_existing_class, "Person", mock_client)
 
         # get_document should NOT have been called for xsd:string
         assert not mock_client.get_document.called
@@ -623,7 +623,7 @@ def test_embed_obj_skips_same_class(self):
 
         all_existing_class = {"Person": {"name": "xsd:string", "friend": "Person"}}
 
-        result = _embed_obj(df, 1, pd, False, all_existing_class, "Person", mock_client)
+        _embed_obj(df, 1, pd, False, all_existing_class, "Person", mock_client)
 
         # get_document should NOT have been called for same class reference
         assert not mock_client.get_document.called
@@ -640,7 +640,7 @@ def test_embed_obj_skips_enum_types(self):
             "Status": {"@type": "Enum", "values": ["ACTIVE", "INACTIVE"]},
         }
 
-        result = _embed_obj(df, 1, pd, False, all_existing_class, "Person", mock_client)
+        _embed_obj(df, 1, pd, False, all_existing_class, "Person", mock_client)
 
         # get_document should NOT have been called for Enum type
         assert not mock_client.get_document.called