Feature/fileitem factory #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/Token/TokenTest.php # tests/Util/FileUploadNormalizerTest.php
# Conflicts: # tests/EventListener/AdminEmailTokenListenerTest.php
fritzmg
reviewed
Sep 17, 2024
# Conflicts: # tests/Gateway/MailerGatewayTest.php
|
Is that what you need @aschempp? If so, I'll merge this :) |
fritzmg
approved these changes
Sep 23, 2024
aschempp
reviewed
Sep 26, 2024
| } | ||
|
|
||
| /** | ||
| * @throws InvalidFileItemException if the information cannot be fetched automatically (e.g. missing mime type guesser service) |
There was a problem hiding this comment.
Suggested change
| * @throws InvalidFileItemException if the information cannot be fetched automatically (e.g. missing mime type guesser service) | |
| * @throws InvalidFileItemException if the file does not exist) |
There was a problem hiding this comment.
Both comments are correct, you would need to merge them in your suggestion.
| { | ||
| $stream = $virtualFilesystem->readStream($file->getPath()); | ||
|
|
||
| return FileItem::fromStream($stream, $file->getName(), $file->getMimeType(), $file->getFileSize()); |
There was a problem hiding this comment.
does $file->getName() return the "base name" only, or should we apply basename() as well here?
There was a problem hiding this comment.
It does whatever the implementation of the virtualfilesystem does. We don't care here.
| public function createFromLocalPath(string $path): FileItem | ||
| { | ||
| if (!(new Filesystem())->exists($path)) { | ||
| throw new InvalidFileItemException(\sprintf('The file "%s" does not exist.', $path)); |
There was a problem hiding this comment.
maybe we could use the Symfony Filesystem FileNotFoundException here instead? The we also wouldn't need to add a new exception to NC.
There was a problem hiding this comment.
No, it's best practice to use domain exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #360.