Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications fail silently #335

Closed
fritzmg opened this issue May 15, 2024 · 3 comments
Closed

Notifications fail silently #335

fritzmg opened this issue May 15, 2024 · 3 comments
Labels

Comments

@fritzmg
Copy link
Collaborator

fritzmg commented May 15, 2024

Currently if the MailerGateway for example returns a Receipt for an unsuccessful delivery, these failed attempts are not logged anywhere at all.

Should we at least add a system log entry in NotificationCenter::sendParcel() for unsuccessful receipts? This would restore the behavior of NC 1.x (and in Contao 5 these logs would be written to the file log as well).

wdyt?

@Toflar
Copy link
Member

Toflar commented May 22, 2024

Yeah I think I would accept a PR that implements a simple listener for that. The ReceiptEvent can be used for exactly that and log to the system log in case the delivery failed. All the info required for that are part of the Receipt :)

@fritzmg
Copy link
Collaborator Author

fritzmg commented May 22, 2024

Sounds good 👍. Will do a PR when I have the time.

@fritzmg
Copy link
Collaborator Author

fritzmg commented May 23, 2024

See #337

@fritzmg fritzmg closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants