Ensure valid FileItem instances

config/services.php

@@ -62,7 +62,7 @@
 
     $services->set(FileItemFactory::class)
         ->args([
-            service('mime_types'),
+            service('mime_types')->nullOnInvalid(),
         ])
     ;
 

src/BulkyItem/FileItem.php

@@ -5,18 +5,28 @@
 namespace Terminal42\NotificationCenterBundle\BulkyItem;
 
 use Symfony\Component\Filesystem\Filesystem;
+use Terminal42\NotificationCenterBundle\Exception\BulkyItem\InvalidFileItemException;
 
 class FileItem implements BulkyItemInterface
 {
     /**
      * @param resource $contents
+     *
+     * @throws InvalidFileItemException
      */
     private function __construct(
         private $contents,
         private readonly string $name,
         private readonly string $mimeType,
         private readonly int $size,
     ) {
+        try {
+            \assert('' !== $this->name, 'Name must not be empty');
+            \assert('' !== $this->mimeType, 'Mime type must not be empty');
+            \assert($this->size >= 0, 'File size must not be smaller than 0');
+        } catch (\AssertionError $e) {
+            throw new InvalidFileItemException($e->getMessage(), $e->getCode(), $e);
+        }
     }
 
     public function getName(): string
@@ -53,22 +63,27 @@ public static function restore($contents, array $meta): BulkyItemInterface
         return new self($contents, $meta['name'], $meta['type'], $meta['size']);
     }
 
+    /**
+     * @throws InvalidFileItemException
+     */
     public static function fromPath(string $path, string $name, string $mimeType, int $size): self
     {
         if (!(new Filesystem())->exists($path)) {
-            throw new \InvalidArgumentException(\sprintf('The file "%s" does not exist.', $path));
+            throw new InvalidFileItemException(\sprintf('The file "%s" does not exist.', $path));
         }
 
         return new self(fopen($path, 'r'), $name, $mimeType, $size);
     }
 
     /**
      * @param resource $resource
+     *
+     * @throws InvalidFileItemException
      */
     public static function fromStream($resource, string $name, string $mimeType, int $size): self
     {
         if (!\is_resource($resource)) {
-            throw new \InvalidArgumentException('$contents must be a resource.');
+            throw new InvalidFileItemException('$contents must be a resource.');
         }
 
         return new self($resource, $name, $mimeType, $size);

src/BulkyItem/FileItemFactory.php

@@ -8,26 +8,33 @@
 use Contao\CoreBundle\Filesystem\VirtualFilesystemInterface;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Mime\MimeTypeGuesserInterface;
+use Terminal42\NotificationCenterBundle\Exception\BulkyItem\InvalidFileItemException;
 
 class FileItemFactory
 {
-    public function __construct(private readonly MimeTypeGuesserInterface $mimeTypeGuesser)
+    public function __construct(private readonly MimeTypeGuesserInterface|null $mimeTypeGuesser = null)
     {
     }
 
+    /**
+     * @throws InvalidFileItemException if the information cannot be fetched automatically (e.g. missing mime type guesser service)
+     */
     public function createFromLocalPath(string $path): FileItem
     {
         if (!(new Filesystem())->exists($path)) {
             throw new \InvalidArgumentException(\sprintf('The file "%s" does not exist.', $path));
         }
 
         $name = basename($path);
-        $mimeType = (string) $this->mimeTypeGuesser->guessMimeType($path);
+        $mimeType = (string) $this->mimeTypeGuesser?->guessMimeType($path);
         $size = (int) filesize($path);
 
         return FileItem::fromPath($path, $name, $mimeType, $size);
     }
 
+    /**
+     * @throws InvalidFileItemException
+     */
     public function createFromVfsFilesystemItem(FilesystemItem $file, VirtualFilesystemInterface $virtualFilesystem): FileItem
     {
         $stream = $virtualFilesystem->readStream($file->getPath());

src/Exception/BulkyItem/InvalidFileItemException.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Terminal42\NotificationCenterBundle\Exception\BulkyItem;
+
+class InvalidFileItemException extends \InvalidArgumentException
+{
+}

tests/BulkyItem/FileItemTest.php

@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Terminal42\NotificationCenterBundle\Test\BulkyItem;
+
+use PHPUnit\Framework\TestCase;
+use Terminal42\NotificationCenterBundle\BulkyItem\FileItem;
+use Terminal42\NotificationCenterBundle\Exception\BulkyItem\InvalidFileItemException;
+
+class FileItemTest extends TestCase
+{
+    public function testCannotCreateEmptyNameFileItem(): void
+    {
+        $this->expectException(InvalidFileItemException::class);
+        $this->expectExceptionMessage('Name must not be empty');
+
+        FileItem::fromPath(__DIR__.'/../Fixtures/name.jpg', '', 'image/jpg', 0);
+    }
+
+    public function testCannotCreateEmptyMimeTypeFileItem(): void
+    {
+        $this->expectException(InvalidFileItemException::class);
+        $this->expectExceptionMessage('Mime type must not be empty');
+
+        FileItem::fromPath(__DIR__.'/../Fixtures/name.jpg', 'name.jpg', '', 0);
+    }
+
+    public function testCannotCreateInvalidFileSizeFileItem(): void
+    {
+        $this->expectException(InvalidFileItemException::class);
+        $this->expectExceptionMessage('File size must not be smaller than 0');
+
+        FileItem::fromPath(__DIR__.'/../Fixtures/name.jpg', 'name.jpg', 'image/jpg', -42);
+    }
+}