Update settings_migrator.js

Author: justkeepquiet

manifest.json

@@ -28,7 +28,7 @@
         "Readme.md": "3ac4814b63238ce81803ba6464bc4eaf70fea090cd4d7b42d3d6dcce7d243719",
         "index.js": "d05762c098b1ed00f9426aa652e6db3c46dc555f58111b69cf1350e3b4c512a8",
         "module.json": "d8266ebae054a5b2dca9c17cf4033b24ffd0d493ab48e398dc7b1efef7dd9856",
-        "settings_migrator.js": "def6b1261793917ce7e88b753ac5b41834630f4846646cbc0065fb2d3d342784",
+        "settings_migrator.js": "9b51556fec65d12c7905c2df26b8e04b9b762b9692f0c358b763a07ecf5cae12",
         "settings_structure.js": "0a16a94bcf1fb926654d96bcdd9b8237db644b42d71fe1cc882b12fdbbb22a1f"
     }
 }

settings_migrator.js

@@ -11,14 +11,26 @@ const DefaultSettings = {
 }
 
 module.exports = function MigrateSettings(from_ver, to_ver, settings) {
-    if (from_ver === undefined) {
-        // Migrate legacy config file
-        return Object.assign(Object.assign({}, DefaultSettings), settings);
-    } else if (from_ver === null) {
-        // No config file exists, use default settings
-        return DefaultSettings;
-    } else {
-        // Migrate from older version (using the new system) to latest one
-        throw new Error('So far there is only one settings version and this should never be reached!');
+    if (from_ver === undefined) return { ...DefaultSettings, ...settings };
+    else if (from_ver === null) return DefaultSettings;
+    else {
+        from_ver = Number(from_ver);
+        to_ver = Number(to_ver);
+        if (from_ver + 1 < to_ver) {
+            settings = MigrateSettings(from_ver, from_ver + 1, settings);
+            return MigrateSettings(from_ver + 1, to_ver, settings);
+        }
+        const oldsettings = settings;
+        switch (to_ver) {
+            default:
+                settings = Object.assign(DefaultSettings, {});
+
+                for (const option in oldsettings) {
+                    if (settings[option] !== undefined) {
+                        settings[option] = oldsettings[option];
+                    }
+                }
+        }
+        return settings;
     }
-}
+};