Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YoloV4 inference server #52

Merged
merged 11 commits into from
Dec 23, 2024
Merged

Add YoloV4 inference server #52

merged 11 commits into from
Dec 23, 2024

Conversation

bgoelTT
Copy link
Contributor

@bgoelTT bgoelTT commented Dec 7, 2024

This PR adds the YoloV4 inference server from tt-metal to tt-inference server and provides utilities to build and test it.

NOTE: I have not added an evaluation test for the model but can do that. Also, I think we might want to start restructuring the root tests/ directory to contain all tests, organized by each inference server app (i.e., vllm-tt-metal-llama3-70b, tt-metal-mistral-7b etc)

@bgoelTT bgoelTT requested a review from tstescoTT December 7, 2024 00:10
@bgoelTT bgoelTT requested a review from milank94 December 12, 2024 17:24
tt-metal-yolov4/README.md Outdated Show resolved Hide resolved
tt-metal-yolov4/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@milank94 milank94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you running any sort of linting on the files i.e. ruff?

@bgoelTT
Copy link
Contributor Author

bgoelTT commented Dec 13, 2024

Are you running any sort of linting on the files i.e. ruff?

@milank94 yes, ruff is run as a precommit condition if and only if the development venv is active. All commits have been made after ruff was run.

@bgoelTT bgoelTT requested a review from milank94 December 18, 2024 15:08
Copy link
Contributor

@milank94 milank94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bgoelTT bgoelTT merged commit dddad09 into main Dec 23, 2024
1 check passed
@bgoelTT bgoelTT deleted the ben/yolov4 branch December 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants