Increase kMaxEvents and error out when it's exceeded #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior silently resets and overwrites the internal list, this PR changes it to error out instead. BUG=b/264555999
advaitjain
reviewed
Mar 21, 2023
| "MicroProfiler errored out because total number of events exceeded the " | ||
| "maximum of %d.", | ||
| kMaxEvents); | ||
| TFLITE_DCHECK(false); |
There was a problem hiding this comment.
nit: use TFLITE_ASSERT_FALSE instead?
advaitjain
approved these changes
Mar 21, 2023
|
@Mergifyio refresh |
✅ Pull request refreshed |
advaitjain
approved these changes
Mar 21, 2023
advaitjain
approved these changes
Mar 21, 2023
rascani
added a commit
to rascani/tflite-micro
that referenced
this pull request
Dec 4, 2023
The MicroProfiler was updated in PR tensorflow#1835 to abort when the event arrays fill up rather than wrap around. This PR updates the documentation to match the behavior. BUG=tensorflow#2272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior silently resets and overwrites the internal list, this PR changes it to error out instead.
BUG=b/264555999