[tfjs-node] replace deprecated utils #8425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
|
+1 |
|
+1 |
|
@mattsoulanille can you review this? The fix looks correct and it blocks being able to use tfjs-node on Node >=23. |
|
any news on this? |
|
Same thing, on node 23 (and above) this is absolutely needed. Is there a reason for it not being merged ? |
|
+1 |
mattsoulanille
approved these changes
Apr 23, 2025
|
Thanks! We're currently changing our CI config, so I've run this locally to verify it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after been marked as deprecated in node 22, node 23 removed nearly all its
util.is*functions. so using the node backend in 23 fails quite loudly with some "TypeError: util_1.isNullOrUndefined is not a function".this PR replace the few places where theses functions were used with node's recommended fixes. or with nullish-coalescing where appropriate.