Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate uses of struct.to_proto #6801

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

c-mita
Copy link
Contributor

@c-mita c-mita commented Mar 20, 2024

Reapplies #6778 after #6721 inadvertently reverted part of it.

The "to_proto" method on Starlark structs is deprecated and shouldn't be used. Instead, the proto module's "encode_text" function should be used. (https://bazel.build/rules/lib/toplevel/proto)

It, along with "to_json", can be disabled in Bazel using the flag --incompatible_struct_has_no_methods

The underlying implementation is the same, so there should be no observable changes in final outputs.

Reapplies tensorflow#6778 after
tensorflow#6721 inadvertently
reverted part of it.

The "to_proto" method on Starlark structs is deprecated and shouldn't be
used. Instead, the proto module's "encode_text" function should be used.
(https://bazel.build/rules/lib/toplevel/proto)

It, along with "to_json", can be disabled in Bazel using the flag
--incompatible_struct_has_no_methods

The underlying implementation is the same, so there should be no
observable changes in final outputs.
@bmd3k bmd3k merged commit 8f3deeb into tensorflow:master Mar 26, 2024
13 checks passed
AnuarTB pushed a commit to AnuarTB/tensorboard that referenced this pull request May 3, 2024
Reapplies tensorflow#6778 after
tensorflow#6721 inadvertently
reverted part of it.

The "to_proto" method on Starlark structs is deprecated and shouldn't be
used. Instead, the proto module's "encode_text" function should be used.
(https://bazel.build/rules/lib/toplevel/proto)

It, along with "to_json", can be disabled in Bazel using the flag
--incompatible_struct_has_no_methods

The underlying implementation is the same, so there should be no
observable changes in final outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants