Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Colab serve_kernel_port_as_iframe API #4737

Open
wchargin opened this issue Mar 5, 2021 · 0 comments
Open

Use Colab serve_kernel_port_as_iframe API #4737

wchargin opened this issue Mar 5, 2021 · 0 comments
Labels
core:backend type:cleanup

Comments

@wchargin
Copy link
Contributor

wchargin commented Mar 5, 2021

The Colab folks have upstreamed our iframe creation logic with a helper
modeled after ours:

https://github.com/googlecolab/colabtools/blob/f31c2c03993b733b8f5ae7c7a451077f72ca6882/google/colab/output/_util.py#L66-L78

It’s available as:

from google.colab import output
output.serve_kernel_port_as_iframe(port)

…and we already only render to Colab if google.colab is present.
May as well use it, simplifying our code a bit?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core:backend type:cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wchargin