Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove type error suppression in webcomponents-externs #2425

Open
stephanwlee opened this issue Jul 15, 2019 · 0 comments
Open

cleanup: remove type error suppression in webcomponents-externs #2425

stephanwlee opened this issue Jul 15, 2019 · 0 comments

Comments

@stephanwlee
Copy link
Contributor

let statements in https://github.com/Polymer/polymer/blob/2.x/externs/webcomponents-externs.js causes serious type error like below:

Jul 15, 2019 8:33:41 AM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: external/org_polymer_externs/externs/webcomponents-externs.js:15: WARNING - [JSC_BLOCK_SCOPED_DECL_MULTIPLY_DECLARED_ERROR] Duplicate let / const / class / function declaration in the same scope is not allowed.
let HTMLImports = {
    ^^^^^^^^^^^^^^^

Jul 15, 2019 8:33:41 AM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: external/org_polymer_externs/externs/webcomponents-externs.js:15: WARNING - [JSC_REDECLARED_VARIABLE_ERROR] Illegal redeclared variable: HTMLImports                         
let HTMLImports = {
    ^^^^^^^^^^^^^^^

Newer externs for (v3; internal version matches that of v3) seems to be okay.
https://github.com/Polymer/polymer/blob/master/externs/webcomponents-externs.js

@stephanwlee stephanwlee self-assigned this Jul 15, 2019
@stephanwlee stephanwlee removed their assignment Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant