Adds hparam column persistence

Author: hoonji

tensorboard/webapp/hparams/BUILD

@@ -37,7 +37,9 @@ tf_ng_module(
         "//tensorboard/webapp/hparams/_redux:hparams_actions",
         "//tensorboard/webapp/hparams/_redux:hparams_module",
         "//tensorboard/webapp/hparams/_redux:hparams_selectors",
+        "//tensorboard/webapp/persistent_settings:config_module",
         "@npm//@angular/core",
+        "@npm//@ngrx/store",
     ],
 )
 

tensorboard/webapp/hparams/hparams_module.ts

@@ -13,9 +13,26 @@ See the License for the specific language governing permissions and
 limitations under the License.
 ==============================================================================*/
 import {NgModule} from '@angular/core';
+import {createSelector} from '@ngrx/store';
+import {PersistentSettingsConfigModule} from '../persistent_settings/persistent_settings_config_module';
 import {HparamsModule as ReduxModule} from './_redux/hparams_module';
+import {getDashboardDisplayedHparamColumns} from './_redux/hparams_selectors';
+
+export function getRunsTableHeadersFactory() {
+  return createSelector(
+    getDashboardDisplayedHparamColumns,
+    (dashboardDisplayedHparamColumns) => {
+      return {dashboardDisplayedHparamColumns};
+    }
+  );
+}
 
 @NgModule({
-  imports: [ReduxModule],
+  imports: [
+    ReduxModule,
+    PersistentSettingsConfigModule.defineGlobalSetting(
+      getRunsTableHeadersFactory
+    ),
+  ],
 })
 export class HparamsModule {}

tensorboard/webapp/persistent_settings/_data_source/persistent_settings_data_source.ts

@@ -102,6 +102,10 @@ export class OSSSettingsConverter extends SettingsConverter<
       serializableSettings.rangeSelectionHeaders =
         settings.rangeSelectionHeaders;
     }
+    if (settings.dashboardDisplayedHparamColumns !== undefined) {
+      serializableSettings.dashboardDisplayedHparamColumns =
+        settings.dashboardDisplayedHparamColumns;
+    }
     return serializableSettings;
   }
 
@@ -236,6 +240,11 @@ export class OSSSettingsConverter extends SettingsConverter<
       settings.rangeSelectionHeaders = backendSettings.rangeSelectionHeaders;
     }
 
+    if (Array.isArray(backendSettings.dashboardDisplayedHparamColumns)) {
+      settings.dashboardDisplayedHparamColumns =
+        backendSettings.dashboardDisplayedHparamColumns;
+    }
+
     return settings;
   }
 }

tensorboard/webapp/persistent_settings/_data_source/persistent_settings_data_source_test.ts

@@ -420,6 +420,46 @@ describe('persistent_settings data_source test', () => {
 
         expect(actual).toEqual({});
       });
+
+      it('properly converts dashboardDisplayedHparamColumns', async () => {
+        getItemSpy.withArgs(TEST_ONLY.GLOBAL_LOCAL_STORAGE_KEY).and.returnValue(
+          JSON.stringify({
+            dashboardDisplayedHparamColumns: [
+              {
+                type: ColumnHeaderType.HPARAM,
+                name: 'conv_layers',
+                displayName: 'Conv Layers',
+                enabled: true,
+              },
+              {
+                type: ColumnHeaderType.HPARAM,
+                name: 'conv_kernel_size',
+                displayName: 'Conv Kernel Size',
+                enabled: true,
+              },
+            ],
+          })
+        );
+
+        const actual = await firstValueFrom(dataSource.getSettings());
+
+        expect(actual).toEqual({
+          dashboardDisplayedHparamColumns: [
+            {
+              type: ColumnHeaderType.HPARAM,
+              name: 'conv_layers',
+              displayName: 'Conv Layers',
+              enabled: true,
+            },
+            {
+              type: ColumnHeaderType.HPARAM,
+              name: 'conv_kernel_size',
+              displayName: 'Conv Kernel Size',
+              enabled: true,
+            },
+          ],
+        });
+      });
     });
 
     describe('#setSettings', () => {
@@ -503,6 +543,51 @@ describe('persistent_settings data_source test', () => {
           })
         );
       });
+
+      it('properly converts dashboardDisplayedHparamColumns', async () => {
+        getItemSpy
+          .withArgs(TEST_ONLY.GLOBAL_LOCAL_STORAGE_KEY)
+          .and.returnValue(null);
+
+        await firstValueFrom(
+          dataSource.setSettings({
+            dashboardDisplayedHparamColumns: [
+              {
+                type: ColumnHeaderType.HPARAM,
+                name: 'conv_layers',
+                displayName: 'Conv Layers',
+                enabled: true,
+              },
+              {
+                type: ColumnHeaderType.HPARAM,
+                name: 'conv_kernel_size',
+                displayName: 'Conv Kernel Size',
+                enabled: true,
+              },
+            ],
+          })
+        );
+
+        expect(setItemSpy).toHaveBeenCalledOnceWith(
+          TEST_ONLY.GLOBAL_LOCAL_STORAGE_KEY,
+          JSON.stringify({
+            dashboardDisplayedHparamColumns: [
+              {
+                type: ColumnHeaderType.HPARAM,
+                name: 'conv_layers',
+                displayName: 'Conv Layers',
+                enabled: true,
+              },
+              {
+                type: ColumnHeaderType.HPARAM,
+                name: 'conv_kernel_size',
+                displayName: 'Conv Kernel Size',
+                enabled: true,
+              },
+            ],
+          })
+        );
+      });
     });
 
     describe('settings migration', () => {

tensorboard/webapp/persistent_settings/_data_source/types.ts

@@ -46,6 +46,7 @@ export declare interface BackendSettings {
   linkedTimeEnabled?: boolean;
   singleSelectionHeaders?: ColumnHeader[];
   rangeSelectionHeaders?: ColumnHeader[];
+  dashboardDisplayedHparamColumns?: ColumnHeader[];
 }
 
 /**
@@ -70,4 +71,5 @@ export interface PersistableSettings {
   linkedTimeEnabled?: boolean;
   singleSelectionHeaders?: ColumnHeader[];
   rangeSelectionHeaders?: ColumnHeader[];
+  dashboardDisplayedHparamColumns?: ColumnHeader[];
 }