Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Fix step size extraction for checkpoint name #1487

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

lzhang10
Copy link
Contributor

This fixes a bug introduced in 47ced4e

Fix step size extraction for checkpoint name with - in it such as avg-model.ckpt-1234

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author has not signed CLA label Mar 13, 2019
@lzhang10
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lzhang10 lzhang10 force-pushed the fix-step-extraction branch from 147dcb3 to 533eca1 Compare March 13, 2019 15:16
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels Mar 13, 2019
@lzhang10 lzhang10 force-pushed the fix-step-extraction branch from 533eca1 to 71a4db6 Compare March 13, 2019 15:34
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author has not signed CLA and removed cla: yes PR author has signed CLA labels Mar 13, 2019
@lzhang10
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels Mar 13, 2019
@afrozenator
Copy link
Contributor

Thanks a lot for finding and fixing @lzhang10 !!

@afrozenator afrozenator merged commit f23f535 into tensorflow:master Mar 15, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 15, 2019
PiperOrigin-RevId: 238649533
@lzhang10 lzhang10 deleted the fix-step-extraction branch March 16, 2019 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants