This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Add to_unicode_utf8() to text_encoder.py #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
add-to_unicode_utf8
branch
from
014c055 to
ea74871
Compare
|
thanks a lot @cclauss for caring to clean up the code -- this is much much appreciated! |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jan 4, 2019
PiperOrigin-RevId: 227918987
Merged
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
PiperOrigin-RevId: 227918987
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensor2tensor.data_generators currently has two different versions of to_unicode(), one in text_encoder.py and the other in wiki_revision_utils.py. This PR proposes renaming the second version --> to_unicode_utf8() and moving it into text_encoder.py with the other Unicode utility functions.