Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Add Fast Decoding Support For Relative Dot Product #1295

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

aeloyq
Copy link
Contributor

@aeloyq aeloyq commented Dec 12, 2018

Add Fast Decoding Support For And Only For Relative Dot Product by enabling caching mechanism.
This pr have been tested on "En-Zh" case and got the same results as expected.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author has not signed CLA label Dec 12, 2018
@aeloyq
Copy link
Contributor Author

aeloyq commented Dec 12, 2018

Check CLA again.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels Dec 12, 2018
@afrozenator
Copy link
Contributor

thanks a lot @aeloyq !

@afrozenator afrozenator merged commit a9b89de into tensorflow:master Dec 13, 2018
tensorflow-copybara pushed a commit that referenced this pull request Dec 13, 2018
PiperOrigin-RevId: 225286154
@aeloyq
Copy link
Contributor Author

aeloyq commented Dec 13, 2018

There's a typo in

tensor2tensor/models/transformer.py line-276

if self._hparams.self_attention_type not in ["dot_product", "dot_product_relative1"]:

should be modified to:

if self._hparams.self_attention_type not in ["dot_product", "dot_product_relative"]:

@afrozenator
Copy link
Contributor

Thanks - yes @lukaszkaiser pointed that out, we fixed it on our end.

kpe pushed a commit to kpe/tensor2tensor that referenced this pull request Mar 2, 2019
kpe pushed a commit to kpe/tensor2tensor that referenced this pull request Mar 2, 2019
PiperOrigin-RevId: 225286154
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants