This repository was archived by the owner on Jul 7, 2023. It is now read-only.
trainer_lib: add problem hparams after parsing the overrides #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2t-trainer passes problem_name=None to create_hparams(), and adds the problem hparams afterwards when creating the experiment. t2t-decoder instead relies fully on create_hparams() This inconsistency causes t2t-trainer and t2t-decoder to pass different sets of model_hparams to Problem.hparams() (before and after overrides respectively), which is problematic. Always letting the problem see the final version of the model hparams is more useful (in case the problem hparams depend on the model), so make sure the problem is added after the overrides.
lukaszkaiser
approved these changes
Oct 31, 2018
|
Thanks for the PR and sorry for the delay in getting it in! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t2t-trainer passes problem_name=None to create_hparams(), and
adds the problem hparams afterwards when creating the experiment.
t2t-decoder instead relies fully on create_hparams()
This inconsistency causes t2t-trainer and t2t-decoder to pass
different sets of model_hparams to Problem.hparams() (before and
after overrides respectively), which is problematic.
Always letting the problem see the final version of the model
hparams is more useful (in case the problem hparams depend on
the model), so make sure the problem is added after the overrides.