Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Fix the warnings and errors from Cotangent deprecation. #122

Merged
merged 1 commit into from
May 16, 2019
Merged

Fix the warnings and errors from Cotangent deprecation. #122

merged 1 commit into from
May 16, 2019

Conversation

bartchr808
Copy link
Contributor

This PR is parallel to the following change which deprecated Cotangent and removed the tangentVector(from:) method.

@bartchr808 bartchr808 requested review from rxwei and dan-zheng May 16, 2019 18:46
dan-zheng
dan-zheng approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (grep -nr "CotangentVector" Sources Tests shows no remaining usages.)

rxwei
rxwei approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rxwei rxwei merged commit ffba693 into master May 16, 2019
@rxwei rxwei deleted the fix-cotangent-deprecation branch May 16, 2019 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rxwei rxwei rxwei approved these changes

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartchr808 @rxwei @dan-zheng