Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifted structure loss #342

Merged

Conversation

Lorenzobattistela
Copy link
Contributor

This PR refers to Issue #102 and it is implementing the LSL described in the article https://arxiv.org/pdf/1511.06452.pdf

@google-cla
Copy link

google-cla bot commented Jul 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Lorenzobattistela
Copy link
Contributor Author

@owenvallis fixed the CLA problem, same changes from before.

@owenvallis
Copy link
Collaborator

Looks like the tests/losses/test_lifted_structure_loss.py just needs to be formatted and then the PR should be good to go.

@Lorenzobattistela
Copy link
Contributor Author

@owenvallis Sorry took so long, I missed your comment in the notifications. I ran black black . --verbose --check in my branch locally, and i got this output:
Oh no! 💥 💔 💥 14 files would be reformatted, 144 files would be left unchanged.

But i commited only the change in test_lsl, since it was the file related to this PR. If it is needed to change other things, just tag me and I'll do it. Thanks!

@owenvallis
Copy link
Collaborator

Looks like there are some isort errors with the import formatting but that shouldn't block us here. I'll format the imports on my side.

Thanks again for implementing the loss!

@owenvallis owenvallis merged commit fc00864 into tensorflow:master Aug 8, 2023
2 of 6 checks passed
@Lorenzobattistela
Copy link
Contributor Author

Appreciate all the help, I'll keep contributing to similarity. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants